Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running configu export --explain shows hidden keys #393

Open
RonConfigu opened this issue Mar 11, 2024 · 3 comments
Open

Running configu export --explain shows hidden keys #393

RonConfigu opened this issue Mar 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@RonConfigu
Copy link
Contributor

Current Behavior

Even though I've set a config to be hidden in my .cfgu the explain flag shows its value
image
image

Expected Behavior

Not for me to decide.
I would assume it should be hidden here too.

To Reproduce

  1. Create .cfgu with a key marked hidden and default value
  2. Run configu eval | export --explain

Context

No response

@RonConfigu RonConfigu added the bug Something isn't working label Mar 11, 2024
@Maran1947
Copy link
Contributor

Upon investigating the issue, I observed that there is a check for the --explain flag, which correctly handles hidden configurations when the flag is not present. However, the explainConfigs(pipe) method does not currently filter out hidden configurations. Based on my understanding, to ensure these configurations are not included in the output when the --explain flag is used, I propose adding a filter for hidden configurations inside the explainConfigs(pipe) method.

Could you please provide your input on this? I would appreciate it if you could assign this issue to me as I am eager to work on it and contribute to improving Configu's functionality.

@RichardAkman
Copy link
Contributor

@Maran1947, Thank you for your diligence in investigating this matter and proposing a solution. Your dedication to improving Configu's functionality is greatly appreciated.

We're currently in the process of evaluating our product requirements to ensure that any changes align with our overarching goals and objectives. Once we've concluded this evaluation, we'll provide further guidance on how to proceed with this issue.

Your eagerness to contribute is commendable, and we'll be sure to keep you updated on any developments regarding this issue.

@Maran1947
Copy link
Contributor

Thank you for the update. I'm eagerly awaiting further guidance. In the meantime, if you have a moment, could you please suggest any priority issues you've identified? I'd absolutely love to work on those and make more meaningful contributions to Configu. I'm currently exploring the issue tab with curiosity, searching for the task to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants