Ignores :not_found error when reseting InMemory store
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashdotdash
changed the title
:not_found error when reseting InMemory store
slashdotdash
added a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is just a problem in our codebase, or if it should also be handled here in some way, so opening the discussion.
After getting our commanded 1.0 upgrade ready, we're having a few sporading build errors because
InMemory.reset!sometimes fails with{:error, :not_found}.We believe this is caused when somehow a handler ends up stopping when cleaning up the test, but before the reset call is made. Since this only affects the clean-up part of a test, I feel it should be safe to ignore this particular error