Fix Aggregate initialization races #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for an Aggregate to receive an command before it's state is initialized. This leads to execute/2 handlers receiving `nil` for the aggregate state. It appears to happen more often when using a distributed process registry. The fix is to replace the casts in the init/1 handler with a chain of handle_continue/2 callbacks that are guaranteed to complete before the first message is handled. COMPATIBILITY NOTE: GenServer.handle_continue/2 requires OTP-21 or greater
|
Thanks for the pull request @uberbrodt. |
slashdotdash
added a commit
that referenced
this pull request
Jun 10, 2019
Remove obsolete `handle_cast/2` functions replaced by `handle_continue/2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for an Aggregate to receive an command before it's state
is initialized. This leads to execute/2 handlers receiving
nilfor theaggregate state. It appears to happen more often when using a
distributed process registry. The fix is to replace the casts in the
init/1 handler with a chain of handle_continue/2 callbacks that are
guaranteed to complete before the first message is handled.
COMPATIBILITY NOTE: GenServer.handle_continue/2 requires OTP-21 or greater