Handle custom type serialization in snapshot source type #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype for sanpshot source type
slashdotdash
requested changes
Apr 8, 2018
slashdotdash
requested changes
Apr 8, 2018
| @@ -406,7 406,7 @@ defmodule Commanded.Aggregates.Aggregate do | |||
| snapshot = %SnapshotData{ | |||
| source_uuid: aggregate_uuid, | |||
| source_version: aggregate_version, | |||
| source_type: Atom.to_string(aggregate_module), | |||
| source_type: TypeProvider.to_string(aggregate_module), | |||
There was a problem hiding this comment.
This breaks the contract specified by the Commanded.EventStore.TypeProvider behaviour since it expects a struct to be provided, not the module atom.
Instead, you can just pass in the aggregate_state.
There was a problem hiding this comment.
Will do.
Thank for noticing that I break the behavior defined by the TypeProvider.
|
Is there anything you want to change? |
|
Sorry, forgot to merge in after your changes. Thanks @jccf091. |
slashdotdash
added a commit
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.