Allows for a default consistency to be set via the env #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * In some situations, particularly when testing, we'll want to have strong consistency, but that might not be true for the same operation in a different environment. So, it would be very helpful to be able to switch between types of consistency per environment. This change addresses the need by: * Changing the default from being straight up `:eventual` but instead to search on the env first and only if nothing is found, then it will choose `:eventual`
|
@zamith Thanks for the pull request. |
slashdotdash
added a commit
that referenced
this pull request
Mar 5, 2018
Document new `default_consistency` config setting.
slashdotdash
added a commit
that referenced
this pull request
Mar 5, 2018
Document new `default_consistency` config setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
strong consistency, but that might not be true for the same operation
in a different environment. So, it would be very helpful to be able to
switch between types of consistency per environment.
This change addresses the need by:
:eventualbut instead tosearch on the env first and only if nothing is found, then it will
choose
:eventualPS: You'll notice that there are no tests for the router change. That is because it is set in a module attribute, which being a compile time evaluated property means I cannot affect from the spec. The only way I could think of testing it, would be to create a new environment just for that purpose, which might be an overkill. What do you think?