-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process Manager listening for unwanted Commands, and creating a junk snapshot. #25
Comments
I am thinking about implementing a FSM data structure, so this kind of problem couldn't happen. Makes sense ? Should I proceed an PR ? |
Yes, you've discovered an issue in that area. The Feel free to work on a pull request. I use Saša's fsm library in the eventstore. Otherwise I'll add this to the roadmap and get it fixed. |
Please, add to the roadmap, I still have to study the code to know how to fix this bug |
It's in the backlog of the Development roadmap. |
Is this still known to be an issue? |
@Trevoke Process managers are comprised of two components: a router and many instances. The router subscribes to the event store and routes events to instances, this might require starting a new process or resuming an existing one. A process manager instance handles the event, returning any relevant commands, then mutates its state. It records a snapshot of the mutated state after each event it processes. I'm in the process of reworking process managers so that they use linked events as their persistence mechanism (event sourcing), with optional state snapshots so they resemble how aggregates persist their state. That change will resolve this issue. |
Fixed by #181. |
When making a simple account creation and deposit, I observed that a snapshot was created even with no process manager command. Notice that the source_uuid [left postgre window] has used the "transfer_uuid" from the DepositMoney command.
The text was updated successfully, but these errors were encountered: