Merge pull request #542 from janpieper/fix-logger-warn-deprecation

Use `Logger.warning` to fix deprecation warnings
commanded · Dec 11, 2023 · dcf48d9 · dcf48d9
2 parents e20fddd 3eac92f
commit dcf48d9
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -19,7 19,7 @@ You can use Commanded with one of the following event stores for persistence:
 
 Please refer to the [CHANGELOG](CHANGELOG.md) for features, bug fixes, and any upgrade advice included for each release.
 
-Requires Erlang/OTP v21.0 and Elixir v1.9 or later.
 Requires Erlang/OTP v21.0 and Elixir v1.11 or later.
 
 ---
 

diff --git a/lib/commanded/aggregates/aggregate.ex b/lib/commanded/aggregates/aggregate.ex
@@ -444,7 444,7 @@ defmodule Commanded.Aggregates.Aggregate do
  timeout
 
  invalid ->
- Logger.warn(
  Logger.warning(
  "Invalid timeout for aggregate lifespan " <>
  inspect(lifespan) <>
  ", expected a non-negative integer, `:infinity`, `:hibernate`, `:stop`, or `{:stop, reason}` but got: " <>
@@ -863,7 863,7 @@ defmodule Commanded.Aggregates.Aggregate do
  %Aggregate{state | snapshotting: snapshotting}
 
  {:error, error} ->
- Logger.warn(describe(state) <> " snapshot failed due to: " <> inspect(error))
  Logger.warning(describe(state) <> " snapshot failed due to: " <> inspect(error))
 
  state
  end

diff --git a/lib/commanded/event/handler.ex b/lib/commanded/event/handler.ex
@@ -481,7 481,7 @@ defmodule Commanded.Event.Handler do
  case Map.get(context, :failures) do
  too_many when too_many >= 3 ->
  # skip bad event after third failure
- Logger.warn(fn -> "Skipping bad event, too many failures: " <> inspect(event) end)
  Logger.warning(fn -> "Skipping bad event, too many failures: " <> inspect(event) end)
 
  :skip
 
@@ -1045,13 1045,13 @@ defmodule Commanded.Event.Handler do
  confirm_receipt(failed_event, state)
 
  {:stop, reason} ->
- Logger.warn(fn -> describe(state) <> " has requested to stop: #{inspect(reason)}" end)
  Logger.warning(fn -> describe(state) <> " has requested to stop: #{inspect(reason)}" end)
 
  # Stop event handler with given reason
  throw({:error, reason})
 
  invalid ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  describe(state) <> " returned an invalid error response: #{inspect(invalid)}"
  end)
 

diff --git a/lib/commanded/middleware/consistency_guarantee.ex b/lib/commanded/middleware/consistency_guarantee.ex
@@ -44,7 44,7 @@ defmodule Commanded.Middleware.ConsistencyGuarantee do
  pipeline
 
  {:error, :timeout} ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  "Consistency timeout waiting for aggregate #{inspect(aggregate_uuid)} at version #{inspect(aggregate_version)}"
  end)
 

diff --git a/lib/commanded/process_managers/process_manager_instance.ex b/lib/commanded/process_managers/process_manager_instance.ex
@@ -326,12 326,12 @@ defmodule Commanded.ProcessManagers.ProcessManagerInstance do
 
  {:stop, error} ->
  # Stop the process manager instance
- Logger.warn(fn -> describe(state) <> " has requested to stop: #{inspect(error)}" end)
  Logger.warning(fn -> describe(state) <> " has requested to stop: #{inspect(error)}" end)
 
  {:stop, error, state}
 
  invalid ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  describe(state) <> " returned an invalid error response: #{inspect(invalid)}"
  end)
 
@@ -412,7 412,7 @@ defmodule Commanded.ProcessManagers.ProcessManagerInstance do
  dispatch_commands(pending_commands, opts, state, last_event)
 
  {:error, _error} = error ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  describe(state) <>
  " failed to dispatch command " <> inspect(command) <> " due to: " <> inspect(error)
  end)
@@ -508,12 508,12 @@ defmodule Commanded.ProcessManagers.ProcessManagerInstance do
 
  {:stop, reason} = reply ->
  # Stop process manager
- Logger.warn(fn -> describe(state) <> " has requested to stop: #{inspect(reason)}" end)
  Logger.warning(fn -> describe(state) <> " has requested to stop: #{inspect(reason)}" end)
 
  reply
 
  invalid ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  describe(state) <> " returned an invalid error response: #{inspect(invalid)}"
  end)
 

diff --git a/lib/commanded/process_managers/process_router.ex b/lib/commanded/process_managers/process_router.ex
@@ -257,7 257,7 @@ defmodule Commanded.ProcessManagers.ProcessRouter do
  # Stop process router when a process manager instance terminates abnormally.
  @impl GenServer
  def handle_info({:DOWN, _ref, :process, _pid, reason}, %State{} = state) do
- Logger.warn(fn -> describe(state) <> " is stopping due to: #{inspect(reason)}" end)
  Logger.warning(fn -> describe(state) <> " is stopping due to: #{inspect(reason)}" end)
 
  {:stop, reason, state}
  end
@@ -417,12 417,12 @@ defmodule Commanded.ProcessManagers.ProcessRouter do
  ack_and_continue(failed_event, state)
 
  {:stop, reason} ->
- Logger.warn(fn -> describe(state) <> " has requested to stop: #{inspect(error)}" end)
  Logger.warning(fn -> describe(state) <> " has requested to stop: #{inspect(error)}" end)
 
  {:stop, reason, state}
 
  invalid ->
- Logger.warn(fn ->
  Logger.warning(fn ->
  describe(state) <> " returned an invalid error response: #{inspect(invalid)}"
  end)
 

diff --git a/mix.exs b/mix.exs
@@ -7,7 7,7 @@ defmodule Commanded.Mixfile do
  [
  app: :commanded,
  version: @version,
- elixir: "~> 1.10",
  elixir: "~> 1.11",
  elixirc_paths: elixirc_paths(Mix.env()),
  deps: deps(),
  description: description(),