Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hardcoded it into the base
DbApi
/Query
APIs, rather than as a dialect. Sqlite doesn't support it, but it is a builtin part of the JDBC interface, so it's a bit on the fence which side it should go. But the fact that it does need special support in the coreDbApi
implementation makes me lean towards treating it as a builtinWe need to pass an explicit
[R]
type parameter to.getGeneratedKeys
because ourTable
model is not rich enough to tell us what the auto generated primary keys of the table are. This is in contrast to richer models like SLICK which do contain this information. We can streamline this later if necessary, but passing in[Int]
or whatever is not a huge hardship.