Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need for automatically building "bundled" colyseus.js file when @colyseus/schema updates #103

Open
endel opened this issue Jan 12, 2022 · 1 comment
Open

Need for automatically building "bundled" colyseus.js file when @colyseus/schema updates #103

endel opened this issue Jan 12, 2022 · 1 comment

Comments

@endel
Copy link
Member

endel commented Jan 12, 2022

The bundleddist/colyseus.js contains both the Colyseus SDK and @colyseus/schema bundled together.

Problem

When hotfixes are applied to @colyseus/schema the bundled colyseus.js can get behind.

Places where the bundled dist/colyseus.js is used currently are:

  • Webpack, which uses "browser" version by default (

    colyseus.js/package.json

    Line 23 in 9b9b718

    "browser": "dist/colyseus.js",
    )
  • Construct 3 Plugin
  • Cocos Creator Plugin

Solution

The proposed solution here would be to somehow rebuild the dist/colyseus.js file whenever a new @colyseus/schema version gets released. Probably doable through GitHub actions.

  • Publish colyseus.js to NPM
  • Upload Construct 3 Plugin
  • Upload Cocos Creator Plugin
@ShukantPal
Copy link

I was just passing by this repo and found this issue. Unsolicited advice: At PixiJS, we use a monorepo and have a "bundle" type of package (pixi.js is one). You could split everything colyseus.js into other packages and then colyseus.js just re-exports the components (i.e. @colyseus/* stuff). Each time you publish your monorepo, all dependents of changed packages will get republished. That includes your bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endel @ShukantPal