Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated self-cimports in pyx files and other Cython 3 prep #179

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 12, 2023

These self-imports from the pxd file are no longer needed (even in Cython 0.29.x).

Also replacing Python-2 style relative cimports with absolute cimports throughout.

@mkoeppe mkoeppe changed the title Remove outdated self-cimports in pyx files (Cython 3 prep) Remove outdated self-cimports in pyx files and other Cython 3 prep Oct 12, 2023
@tkralphs
Copy link
Member

Hi @mkoeppe, I've been watching this PR, but the build is still failing in a way I can't interpret. Are you looking at this? Should I just wait?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 19, 2023

Which failures are you referring to? In the checks, the wheel build for PyPy 3.9 is failing, but I don't think it has anything to do with this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 19, 2023

In sagemath/sage#36439 I have the final missing piece for switching to Cython 3, but I've backed it out from this PR here to keep the scope limited.

@tkralphs
Copy link
Member

Which failures are you referring to? In the checks, the wheel build for PyPy 3.9 is failing, but I don't think it has anything to do with this PR.

OK, I didn't realize that it was the PyPy build that was failing, but yes, that's what I was referring to. Since that build looks to have been working up until this PR, I guessed it must be related. Perhaps that's not the case, but then should we should we either try to figure it out or remove that build before merging?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 19, 2023

Let's take that to:

@tkralphs tkralphs closed this Oct 20, 2023
@tkralphs tkralphs reopened this Oct 20, 2023
@tkralphs
Copy link
Member

Looking good now. Ready to merge?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2023

Yes, please go ahead

@tkralphs tkralphs merged commit 615a193 into coin-or:master Oct 20, 2023
12 of 13 checks passed
@mkoeppe mkoeppe deleted the cython3 branch October 20, 2023 18:49
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2023

As the next step, I will prepare a PR that switches from Cython < 3 to Cython >= 3; that's now #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants