Fix Preference"s types #2971
Merged
Fix Preference"s types #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 1fbcdb1 is at https://pr2971.build.csb.dev/s/new. |
CompuIves
approved these changes
Nov 5, 2019
|
Yeah it"s a really nice generic type to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updated the props of
Preferenceand it"s child components and also refactored the child components toFunctionComponents.Follow-up of #2861
What is the current behavior?
Preference"s child components areClassComponentsPreference"s child components export their props separately so they can be used byPreferenceWhat is the new behavior?
Preference"s child components areFunctionComponentsPreference"s child components don"t export their props separately andPreferencederives the props of his child components by using theComponentPropsgenericChecklist