feat(ci): refactor build workflow #5572

jsjoeio · 2022-09-19T19:55:25Z

This PR does some major refactoring to our build.yaml workflow, specifically the prebuild step. The two themes of this PR are:

parallelization
fail-fast

It splits up the prebuild jobs - lint, format, etc - and runs them in separate jobs so they can run in parallel. It also adds a new step to each which cancels the entire workflow if any of them fail. This way, we can fail-fast and not waste developer time or CI minutes. Plus, it allows us to run these prebuild checks in parallel to building code-server which means faster feedback loop.

Fixes N/A

This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions

This seems more appropriate given this tests how a plugin might work within code-server.

This reverts commit 13286bf.

This reverts commit 6c87b54.

.github/workflows/build.yaml

ci/dev/helm.sh

ci/dev/test-integration.sh

test/integration/test-plugin/src/index.ts

test/unit/node/app.test.ts

codecov · 2022-09-19T20:26:39Z

Codecov Report

Merging #5572 (5f8beae) into main (4223cf6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5572    /-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4223cf6...5f8beae. Read the comment docs.

This reverts commit 158c64d.

Looks like the cancel action workflow can't run on forks due to secrets. See andymckay/cancel-action#4

.github/workflows/build.yaml

code-asher

Looks good to me, I am going to run it on my branch again to double check the changed files stuff then will approve.

code-asher · 2022-09-22T18:07:42Z

.github/workflows/build.yaml

- - name: Run integration tests on standalone release
- run: yarn test:integration
+ - name: Run native module tests on standalone release
+ run: yarn test:native


I like the rename.

code-asher · 2022-09-22T18:39:15Z

The installation tests are failing but I think it is due to an older change, not this PR. I will push up a PR after this merges to fix it.

I am getting lint and build errors but I am not sure why...maybe unrelated to this PR? Investigating.

The Typescript lint check seems to run every time now?

code-asher · 2022-09-22T18:47:11Z

False alarm on the lint step, I thought the changed files worked from commit to next commit but I think it compares to main each time. So I think it is working.

I think we might need fetch-depth: 2 though for when the branch gets merged otherwise the checks would not run on main (they would only run on the PR) based on:

IMPORTANT: For push events you need to include fetch-depth: 0 OR fetch-depth: 2 depending on your use case.

jsjoeio · 2022-09-22T18:54:19Z

So I think it is working.

Nice!

I think we might need fetch-depth: 2

Ah interesting. If understanding right, you want me to add that to every step in build.yaml where we checkout code-server?

code-asher · 2022-09-22T18:55:18Z

If understanding right, you want me to add that to every step in build.yaml where we checkout code-server?

Only on the steps with the changed-files action (so lint-ts and lint-helm).

jsjoeio · 2022-09-22T18:56:57Z

Only on the steps with the changed-files action (so lint-ts and lint-helm).

Done!

code-asher

My build issues seem to have disappeared so maybe it was a cache issue? If it crops up again we can take another look but I think we are good to go. Nicely done!

jsjoeio added 19 commits September 19, 2022 12:36

refactor: remove stylelint

93f6fd2

refactor: move shellcheck to separate job

f36c1f5

refactor: add helm script and job

3028e8e

refactor: add eslint job and yarn script

d8e0dc9

fix(test/tsconfig): exclude test-plugin

0b1cfc9

refactor: delete lint, add typecheck job

fe70ebf

refactor: remove prebuild

bbfbab4

wip: add notes about unit test refactor

74330a1

refactor: delete buggy socket test

a094400

This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions

refactor: move test-plugin to integration suite

bc02005

This seems more appropriate given this tests how a plugin might work within code-server.

wip

64d234e

wip: refactor vscode integration tests

13286bf

refactor: move unit tests to separate job

6c87b54

fix: formatting

42bafc3

Revert "wip: refactor vscode integration tests"

917d92e

This reverts commit 13286bf.

Revert "refactor: move unit tests to separate job"

6ad5d9a

This reverts commit 6c87b54.

feat: collect codecov integration tests

9030873

fixup! feat: collect codecov integration tests

1243d19

fixup! feat: collect codecov integration tests

f339d0d

jsjoeio self-assigned this Sep 19, 2022

jsjoeio requested a review from a team as a code owner September 19, 2022 19:55

jsjoeio marked this pull request as draft September 19, 2022 19:58

jsjoeio added 2 commits September 19, 2022 12:58

fixup!: move helm step

614f047

fixup!: update ids for caching

f9b3bda

jsjoeio commented Sep 19, 2022

View reviewed changes

jsjoeio added 3 commits September 19, 2022 13:07

trigger ci

4527d46

trigger ci

6f7133b

chore: clean up names in security.yaml

08a7fdf

jsjoeio marked this pull request as ready for review September 19, 2022 20:12

jsjoeio added 2 commits September 21, 2022 12:20

fixup!

5de48da

asher: again

77adf7b

jsjoeio force-pushed the jsjoeio/refactor-workflows branch from 25c62ca to 77adf7b Compare September 21, 2022 21:32

jsjoeio added 14 commits September 21, 2022 15:24

try this for ts changes

97842c4

fixup

6c8261a

refactor: scripts.yml -> scripts.yaml

c57dfe5

fixup!: move lint-sh to scripts.yaml

5a6d486

fixup!: use apk for lint scripts

33163e8

fixup! fixup!: use apk for lint scripts

76168c9

fixup!: remove typecheck step

91fdc7e

fix: pattern for lint ts files

1ed536b

test: lint should fail

158c64d

fixup! fixup!: use apk for lint scripts

3b9e677

Revert "test: lint should fail"

27312a5

This reverts commit 158c64d.

fixup!: skip cancel workflow on forks

eb2b181

Looks like the cancel action workflow can't run on forks due to secrets. See andymckay/cancel-action#4

fixup: remove cancel-workflow

3c15bf1

fixup! fixup! fixup!: use apk for lint scripts

185d259

code-asher reviewed Sep 22, 2022

View reviewed changes

.github/workflows/build.yaml Outdated Show resolved Hide resolved

jsjoeio added 2 commits September 22, 2022 11:07

fixup! fixup! fixup!: use apk for lint scripts

bfb6c01

fixup!: fix yarn key

24776df

code-asher reviewed Sep 22, 2022

View reviewed changes

fixup!: add fetch-depth 0

5f8beae

code-asher approved these changes Sep 22, 2022

View reviewed changes

jsjoeio merged commit 51677f0 into coder:main Sep 22, 2022

jsjoeio deleted the jsjoeio/refactor-workflows branch September 22, 2022 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ci): refactor build workflow #5572

feat(ci): refactor build workflow #5572

jsjoeio commented Sep 19, 2022 •

edited

Loading

codecov bot commented Sep 19, 2022 •

edited

Loading

code-asher left a comment

code-asher Sep 22, 2022

code-asher commented Sep 22, 2022

code-asher commented Sep 22, 2022 •

edited

Loading

jsjoeio commented Sep 22, 2022

code-asher commented Sep 22, 2022

jsjoeio commented Sep 22, 2022

code-asher left a comment

feat(ci): refactor build workflow #5572

feat(ci): refactor build workflow #5572

Conversation

jsjoeio commented Sep 19, 2022 • edited Loading

codecov bot commented Sep 19, 2022 • edited Loading

Codecov Report

code-asher left a comment

Choose a reason for hiding this comment

code-asher Sep 22, 2022

Choose a reason for hiding this comment

code-asher commented Sep 22, 2022

code-asher commented Sep 22, 2022 • edited Loading

jsjoeio commented Sep 22, 2022

code-asher commented Sep 22, 2022

jsjoeio commented Sep 22, 2022

code-asher left a comment

Choose a reason for hiding this comment

jsjoeio commented Sep 19, 2022 •

edited

Loading

codecov bot commented Sep 19, 2022 •

edited

Loading

code-asher commented Sep 22, 2022 •

edited

Loading