Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test for open #5256

Merged
merged 2 commits into from
Jun 13, 2022
Merged

feat: add test for open #5256

merged 2 commits into from
Jun 13, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jun 10, 2022 •
edited
Loading

This PR adds a test for open.

Related to #5153

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

✨ code-server docs for PR #5256 is ready! It will be updated on every commit.

@jsjoeio jsjoeio self-assigned this Jun 10, 2022
@jsjoeio jsjoeio added the testing Anything related to testing label Jun 10, 2022
@jsjoeio jsjoeio added this to the June 2022 milestone Jun 10, 2022
@jsjoeio jsjoeio changed the title wip feat: add test for open Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #5256 (71689b4) into main (744b301) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5256       /-   ##
==========================================
  Coverage   72.00%   72.12%    0.11%     
==========================================
  Files          30       30              
  Lines        1668     1668              
  Branches      367      367              
==========================================
  Hits         1201     1203        2     
  Misses        400      399       -1     
  Partials       67       66       -1
Impacted Files Coverage Δ
src/node/util.ts 88.57% <0.00%> ( 1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744b301...71689b4. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm June 10, 2022 22:27 Inactive
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5256!

  • Last publish status: success
  • Commit: 71689b4

To install in a local project, run:

npm install @coder/code-server-pr@5256

To install globally, run:

npm install -g @coder/code-server-pr@5256

@jsjoeio jsjoeio temporarily deployed to npm June 10, 2022 22:48 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review June 10, 2022 22:51
@jsjoeio jsjoeio requested a review from a team June 10, 2022 22:51
@jsjoeio jsjoeio temporarily deployed to npm June 10, 2022 23:11 Inactive
@jsjoeio jsjoeio enabled auto-merge (squash) June 13, 2022 20:53
@jsjoeio jsjoeio temporarily deployed to npm June 13, 2022 20:57 Inactive
@jsjoeio jsjoeio merged commit a96162d into main Jun 13, 2022
@jsjoeio jsjoeio deleted the jsjoeio/add-open-errtest branch June 13, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsjoeio @code-asher