feat: add additional test for handlePassswordValidation #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ code-server docs for PR #5243 is ready! It will be updated on every commit.
|
jsjoeio
force-pushed
the
jsjoeio/add-password-test
branch
from
17baffa
to
0ee06eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #5243 /- ##
==========================================
Coverage 71.73% 71.85% 0.12%
==========================================
Files 30 30
Lines 1663 1663
Branches 367 367
==========================================
Hits 1193 1195 2
Misses 403 401 -2
Partials 67 67
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional test for
handlePassowrdValidationto ensure the correct behavior happens when passing in an invalidpasswordMethod. Although it shouldn't happen, the new test ensurs thatdefaultcase in the switch statement has coverage.Related to #5153