Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dead code #5188

Merged
merged 4 commits into from
May 10, 2022
Merged

refactor: remove dead code #5188

merged 4 commits into from
May 10, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 10, 2022

This PR removes dead (unused) code. It also moves a function only used in tests to the test helpers section of the codebase.

Changes

  • refactor: delete unused code
  • refactor: move onLine to test helpers

How this was done

  1. npx ts-prune --project tsconfig.json | grep -v '(used in modules)' | grep -v 'typings'
  2. removed code based on functions listed

Related to #5149

@jsjoeio jsjoeio requested a review from a team May 10, 2022 21:58
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 10, 2022
@github-actions
Copy link

github-actions bot commented May 10, 2022

✨ code-server docs for PR #5188 is ready! It will be updated on every commit.

@jsjoeio jsjoeio added this to the May 2022 milestone May 10, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) May 10, 2022 22:23
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #5188 (9aad95b) into main (1788537) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5188       /-   ##
==========================================
- Coverage   71.81%   71.58%   -0.24%     
==========================================
  Files          30       30              
  Lines        1689     1668      -21     
  Branches      374      367       -7     
==========================================
- Hits         1213     1194      -19     
  Misses        408      407       -1     
  Partials       68       67       -1     
Impacted Files Coverage Δ
src/common/util.ts 100.00% <ø> (ø)
src/node/app.ts 100.00% <ø> (ø)
src/node/constants.ts 100.00% <ø> (ø)
src/node/util.ts 83.42% <ø> ( 0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8d487...9aad95b. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm May 10, 2022 22:28 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5188!

  • Last publish status: success
  • Commit: 9aad95b

To install in a local project, run:

npm install @coder/code-server-pr@5188

To install globally, run:

npm install -g @coder/code-server-pr@5188

@jsjoeio jsjoeio merged commit b13849d into main May 10, 2022
@jsjoeio jsjoeio deleted the jsjoeio/rm-dead-code branch May 10, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants