Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for isFile when error #5182

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 9, 2022

This adds an additional test for the isFile utility function to ensure
it returns false in the event of an error.

Related to #5153 #5149

This adds an additional test for the `isFile` utility function to ensure
it returns `false` in the event of an error.
@jsjoeio jsjoeio requested a review from a team May 9, 2022 23:01
@jsjoeio jsjoeio self-assigned this May 9, 2022
@jsjoeio jsjoeio added the testing Anything related to testing label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

✨ code-server docs for PR #5182 is ready! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to npm May 9, 2022 23:06 Inactive
@jsjoeio jsjoeio added this to the May 2022 milestone May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

✨ code-server dev build published to npm for PR #5182!

  • Last publish status: success
  • Commit: 5590633

To install in a local project, run:

npm install @coder/code-server-pr@5182

To install globally, run:

npm install -g @coder/code-server-pr@5182

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #5182 (cef55b1) into main (7c1a45a) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head cef55b1 differs from pull request most recent head 5590633. Consider uploading reports for the commit 5590633 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5182       /-   ##
==========================================
  Coverage   71.73%   71.79%    0.05%     
==========================================
  Files          30       30              
  Lines        1691     1691              
  Branches      375      375              
==========================================
  Hits         1213     1214        1     
  Misses        409      408       -1     
  Partials       69       69              
Impacted Files Coverage Δ
src/node/util.ts 82.22% <0.00%> ( 0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1a45a...5590633. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge (squash) May 9, 2022 23:19
@jsjoeio jsjoeio merged commit 3207bfd into main May 9, 2022
@jsjoeio jsjoeio deleted the jsjoeio/test-util-isFile branch May 9, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants