chore: upgrade Code to 1.66 #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ code-server docs for PR #5135 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5135 /- ##
=======================================
Coverage 71.62% 71.62%
=======================================
Files 30 30
Lines 1688 1688
Branches 375 375
=======================================
Hits 1209 1209
Misses 410 410
Partials 69 69
Continue to review full report at Codecov.
|
They completely changed how auth is handled for GitHub in microsoft/vscode#145424 so our patch may not work. Will need to test and revisit.
It appears they renamed postinstall.js to postinstall.mjs and removed the use of `rimraf` which means our patch is no longer needed! 🎉 microsoft/vscode@b0e8554
added 2 commits
April 27, 2022 20:12
code-asher
reviewed
May 3, 2022
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
73b55d0
to
1ce5da3
Compare
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
aa59fb5
to
d540cec
Compare
This matches the version in ./lib/vscode/remote/.yarnrc. I changed the engine to exactly 16 since if you use any different version it will just not work since the modules will have been built for 16 (due to the .yarnrc).
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
d540cec
to
9cbcfa9
Compare
Node is showing a deprecation warning about it.
The local credentials provider is no longer used when there is a remote so this code moved into the backend web credential provider.
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
956f523
to
e346fe2
Compare
We were using fs.rmdir which presumably did not have the same behavior in v14 (in v16 fs.rmdir also errors).
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
7472eaf
to
f91b228
Compare
code-asher
force-pushed
the
jsjoeio/vscode-1.66
branch
from
f91b228
to
7d99254
Compare
code-asher
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades us to Code 1.66
Changes
Some changes have more details in code or commit messages but here is a brief summary:
parent-origin.diffwhich is needed so that webviews worklast-opened.diffI forgot to remove this in the last Code upgradegithub-auth.diffno longer needed because they changed the auth flownode-version.diffno longer needed because we target node usingremote/package.jsonstore-socket.diffinsecure-notification.diffupdate-check.diffconnection-type.diffTesting plan
Tested the following patches manually:
Fixes #5048