Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide details when update.checked tests fail #5115

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

code-asher
Copy link
Member

Using the toBe* functions will let us know what the actual values are
rather than just telling us true does not equal false.

Hopefully when this flakes again this helps us devise a fix.

Using the toBe* functions will let us know what the actual values are
rather than just telling us true does not equal false.
@code-asher code-asher requested a review from a team April 18, 2022 17:34
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #5115 (6c6684d) into main (7780a13) will not change coverage.
The diff coverage is n/a.

❗ Current head 6c6684d differs from pull request most recent head 58d3289. Consider uploading reports for the commit 58d3289 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5115    /-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files          30       30           
  Lines        1685     1685           
  Branches      374      374           
=======================================
  Hits         1202     1202           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7780a13...58d3289. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@code-asher code-asher merged commit c35bf13 into coder:main Apr 19, 2022
@code-asher code-asher deleted the update-tests branch April 19, 2022 20:46
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Using the toBe* functions will let us know what the actual values are
rather than just telling us true does not equal false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants