Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code comments to QR code generation #517

Merged
merged 16 commits into from
May 6, 2024
Merged

Add code comments to QR code generation #517

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift click to select a range
5c0fcd8
Add code comments
Shane32 May 4, 2024
4aa75e0
Add more comments
Shane32 May 4, 2024
a32ae07
Merge branch 'code_separation' into comments
Shane32 May 4, 2024
4a57c42
Add EciMode comments
Shane32 May 4, 2024
d80278a
Revert code simplification
Shane32 May 4, 2024
b612559
Add blank line
Shane32 May 4, 2024
e71bf0d
More omments
Shane32 May 4, 2024
59bb62d
Apply suggestions from code review
Shane32 May 4, 2024
20dd5a2
Update QRCoder/QRCodeGenerator.Polynom.cs
Shane32 May 4, 2024
cf29ca3
Apply suggestions from code review
Shane32 May 5, 2024
bf04694
Apply suggestions from code review
Shane32 May 5, 2024
3ec9420
Update QRCoder/QRCodeGenerator.cs
Shane32 May 5, 2024
db1c4c4
Merge branch 'master' into comments
Shane32 May 5, 2024
e512a58
Rewrite docs for ECCLevel
Shane32 May 5, 2024
f5a4eaa
Update
Shane32 May 5, 2024
66a4e27
Add comments for GetFormatString
Shane32 May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@Shane32
Shane32 authored May 5, 2024
commit bf046941bc72b8f538c10d116d2642d125694bb1
4 changes: 2 additions & 2 deletions QRCoder/QRCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 713,9 @@ private static int GetCountIndicatorLength(int version, EncodingMode encMode)
private static int GetDataLength(EncodingMode encoding, string plainText, BitArray codedText, bool forceUtf8)
{
// If UTF-8 is forced or the text is detected as UTF-8, return the number of bytes, otherwise return the character count.
return forceUtf8 || IsUtf8(encoding, plainText, forceUtf8) ? (int)((uint)codedText.Length / 8) : plainText.Length;
return forceUtf8 || IsUtf8() ? (int)((uint)codedText.Length / 8) : plainText.Length;

bool IsUtf8(EncodingMode encoding, string plainText, bool forceUtf8)
bool IsUtf8()
{
return (encoding == EncodingMode.Byte && (!IsValidISO(plainText) || forceUtf8));
}
Expand Down