Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modeltools: refactor quantgen forecast vignette to use scale_by_forecaster() and plot_canonical() #463

Open
huisaddison opened this issue Feb 22, 2021 · 1 comment
Open

modeltools: refactor quantgen forecast vignette to use scale_by_forecaster() and plot_canonical() #463

huisaddison opened this issue Feb 22, 2021 · 1 comment

Comments

@huisaddison
Copy link
Collaborator

Vignette code is currently broken with the same issue as #460 ; specifically, scaling is broken (likely due to a breaking change in dependency package)

Rather than patching the vignette code (which implemented scale_by_forecaster() and canonical_plot() by hand), we should just directly call the more robust functions now available in evalcast (branch evalcast-killcards).
@huisaddison huisaddison changed the title refactor quantgen forecast vignette to use scale_by_forecaster() and plot_canonical() modeltools: refactor quantgen forecast vignette to use scale_by_forecaster() and plot_canonical() Feb 22, 2021
@kjytay
Copy link
Contributor

kjytay commented Mar 4, 2021

Also, in the first code chunk, n is set to 21, but the long comment after that assumes that n is 28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjytay @huisaddison