Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: add wasm support #653

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[WIP] feat: add wasm support #653

wants to merge 1 commit into from

Conversation

wzekin
Copy link
Contributor

@wzekin wzekin commented Mar 7, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

增加 wasm 支持

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
zh(optional):

Which issue(s) this PR fixes:

@wzekin wzekin requested review from a team as code owners March 7, 2023 08:43
Duslia
Duslia reviewed Mar 7, 2023
View reviewed changes
pkg/network/dialer/default.go Outdated
//go:build !windows
// build !windows
//go:build !tinygo
// build !tinygo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both

@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 60.60% and no project coverage change

Comparison is base (990b814) 72.52% compared to head (afa46d8) 72.53%.

❗ Current head afa46d8 differs from pull request most recent head 9265383. Consider uploading reports for the commit 9265383 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #653    /-   ##
========================================
  Coverage    72.52%   72.53%           
========================================
  Files           96      101     5     
  Lines         9392     9394     2     
========================================
  Hits          6812     6814     2     
- Misses        2151     2152     1     
  Partials       429      428    -1
Impacted Files Coverage Δ
pkg/app/client/option.go 96.51% <ø> (-0.20%) ⬇️
pkg/app/server/hertz.go 74.35% <ø> ( 1.14%) ⬆️
pkg/app/server/option.go 95.48% <ø> (-0.29%) ⬇️
pkg/app/server/render/html.go 0.00% <ø> (-34.79%) ⬇️
pkg/common/config/option.go 100.00% <ø> (ø)
pkg/network/dialer/default.go 100.00% <ø> (ø)
pkg/protocol/http1/server.go 63.28% <0.00%> ( 0.60%) ⬆️
pkg/route/default.go 100.00% <ø> (ø)
pkg/route/engine.go 60.54% <ø> (ø)
pkg/app/server/render/html_debug.go 43.63% <43.63%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duslia Duslia Duslia left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzekin @Duslia