Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add Go 1.23 to unit tests CI #1171

Merged
merged 5 commits into from
Sep 5, 2024
Merged

build: add Go 1.23 to unit tests CI #1171

merged 5 commits into from
Sep 5, 2024

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Aug 14, 2024 •
edited by welkeyever
Loading

What type of PR is this?

build

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@haoxins haoxins requested review from a team as code owners August 14, 2024 04:05
@GuangmingLuo GuangmingLuo changed the title chore: add Go 1.23 to unit tests build: add Go 1.23 to unit tests CI Aug 14, 2024
@haoxins
Copy link
Contributor Author

haoxins commented Aug 14, 2024 

link: github.com/bytedance/mockey/internal/monkey/common: invalid reference to runtime.sysAllocOS

github.com/bytedance/mockey needs support Go 1.23 :)

@haoxins haoxins mentioned this pull request Aug 14, 2024
Closed
@haoxins
Copy link
Contributor Author

haoxins commented Aug 15, 2024 

link: github.com/bytedance/mockey/internal/monkey/common: invalid reference to runtime.sysAllocOS

github.com/bytedance/mockey needs support Go 1.23 :)

CI should be passed now.

@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (dbd3166) to head (b69c25e).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1171       /-   ##
===========================================
  Coverage    82.61%   82.87%    0.26%     
===========================================
  Files          123       98      -25     
  Lines        11455    10065    -1390     
===========================================
- Hits          9463     8341    -1122     
  Misses        1419     1235     -184     
  Partials       573      489      -84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins marked this pull request as draft August 16, 2024 02:53
@haoxins haoxins marked this pull request as ready for review August 20, 2024 12:43
@haoxins
Copy link
Contributor Author

haoxins commented Aug 20, 2024

Using mockey v1.2.11
bytedance/mockey#61

@GuangmingLuo
Copy link
Member

在 Windows 环境下 ，mockey 还不支持 go 1.23

@GuangmingLuo
Copy link
Member

Please update mockey v1.2.12

@haoxins
Copy link
Contributor Author

haoxins commented Sep 3, 2024

Please update mockey v1.2.12

done

@welkeyever welkeyever merged commit 986797e into cloudwego:develop Sep 5, 2024
18 checks passed
@haoxins haoxins deleted the patch-1 branch September 5, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welkeyever welkeyever welkeyever approved these changes

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoxins @GuangmingLuo @welkeyever