Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(j2t) write redundant base.Base to thrift #55

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix:(j2t) write redundant base.Base to thrift #55

merged 2 commits into from
Jun 11, 2024

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Jun 7, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: j2t.writeThriftBase has written base.Base to thrift message when enabling conv.Options.EnableThriftBase. But native.j2t_write_unset_fields and j2t.handleUnmatchedFields will still try to write this field when user not pass it in JSON (or pass null)
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@AsterDY AsterDY merged commit f16948c into main Jun 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants