Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --experimental-versions (and related flags) as it is now GA #7456

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove --experimental-versions (and related flags) as it is now GA #7456

wants to merge 4 commits into from

Conversation

andyjessop
Copy link
Contributor

Fixes #000.

Removes all references to:

--experimental-versions
--x-versions
--no-experimental-versions
--no-x-versions
experimentalVersions

--experimental-gradual-rollouts
--no-experimental-gradual-rollouts
--x-gradual-rollouts
--no-x-gradual-rollouts

Changes versions and all its subcommands from open-beta to stable.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: already covered by tests.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no existing docs references to experimental-versions (except this one, but it's still relevant)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 12b493a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andyjessop andyjessop force-pushed the aj/remove-x-versions branch from 4cd80c7 to 656283d Compare December 5, 2024 14:53
@andyjessop andyjessop added the e2e Run e2e tests on a PR label Dec 5, 2024
@andyjessop
chore: remove experimentalGradualRollouts flag
7002fd0
@andyjessop
chore: remove experimentalVersions, --x-versions, --experimental-vers…
5672cb5 
…ions, --experimental-gradual-rollouts (and all their opposites)

Remove flags from tests
@andyjessop andyjessop force-pushed the aj/remove-x-versions branch from 656283d to 5672cb5 Compare December 5, 2024 15:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-wrangler-7456

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7456/npm-package-wrangler-7456

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-wrangler-7456 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-create-cloudflare-7456 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-kv-asset-handler-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-miniflare-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-pages-shared-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-vitest-pool-workers-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-workers-editor-shared-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-workers-shared-7456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12183214142/npm-package-cloudflare-workflows-shared-7456

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanushree-sharma tanushree-sharma Awaiting requested review from tanushree-sharma

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
e2e Run e2e tests on a PR
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andyjessop