Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an update command for queues that supports updating messageRetentionPeriod #6442

Closed
wants to merge 2 commits into from
Closed

add an update command for queues that supports updating messageRetentionPeriod #6442

wants to merge 2 commits into from

Conversation

TaraGarg
Copy link

@TaraGarg TaraGarg commented Aug 7, 2024 •
edited
Loading

What this PR solves / how to test

Fixes https://jira.cfdata.org/browse/MQ-667

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

Tara Garg and others added 2 commits August 7, 2024 15:26
add an update command for queues that supports updating messageretent…
394b207 
…ionperiod
@TaraGarg
Merge pull request #1 from TaraGarg/add-queues-update-command
8b7e2d6 
add an update command for queues that supports updating messageretent…
@TaraGarg TaraGarg requested a review from a team as a code owner August 7, 2024 20:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 8b7e2d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TaraGarg TaraGarg marked this pull request as draft August 7, 2024 20:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-wrangler-6442

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6442/npm-package-wrangler-6442

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-wrangler-6442 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-create-cloudflare-6442 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-cloudflare-kv-asset-handler-6442
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-miniflare-6442
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-cloudflare-pages-shared-6442
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10291428247/npm-package-cloudflare-vitest-pool-workers-6442

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@TaraGarg TaraGarg closed this by deleting the head repository Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TaraGarg