Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workers-shared): Project configuration and beta prereleases #6437

Merged
merged 3 commits into from
Aug 8, 2024
Merged

chore(workers-shared): Project configuration and beta prereleases #6437

merged 3 commits into from
Aug 8, 2024
67 −2

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Aug 7, 2024 •
edited
Loading

What this PR solves / how to test

This PR properly sets up the workers-shared project, by putting the necessary linting, TS compilation, and
package.json configuration in place. It also enables @beta prereleases for workers-shared

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: project config change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: project config change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: project config and not user facing
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal change

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner August 7, 2024 10:14
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 21a363a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/asw-publish branch 2 times, most recently from 2049131 to 37e5fcb Compare August 7, 2024 10:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-wrangler-6437

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6437/npm-package-wrangler-6437

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-wrangler-6437 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-create-cloudflare-6437 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-cloudflare-kv-asset-handler-6437
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-miniflare-6437
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-cloudflare-pages-shared-6437
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-cloudflare-vitest-pool-workers-6437
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10298932062/npm-package-cloudflare-workers-shared-6437

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
chore(workers-shared): Put proper project configuration in place
771c0c0 
This commit properly sets up the `workers-shared` project,
by putting the necessary linting, TS compilation, and
`package.json` configuration in place.
@CarmenPopoviciu
chore(gh-actions): Enable @beta prereleases for workers-shared
68b535b
@CarmenPopoviciu
PR feedback
21a363a
@CarmenPopoviciu CarmenPopoviciu merged commit 5d149b9 into main Aug 8, 2024
18 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/asw-publish branch August 8, 2024 09:11
petebacondarwin
petebacondarwin reviewed Aug 8, 2024
View reviewed changes
packages/workers-shared/.eslintrc.js
module.exports = {
root: true,
extends: ["@cloudflare/eslint-config-worker"],
ignorePatterns: ["dist"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eslint-config-worker package already has comprehensive ignore patterns.

workers-sdk/packages/eslint-config-worker/index.js

Lines 8 to 14 in a6a773d

ignorePatterns: [
"**/node_modules/**",
"examples",
"**/templates/**/*.*",
".eslintrc.js",
"**/dist/**",
],

Was there a reason for overriding here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin left review comments

@andyjessop andyjessop andyjessop approved these changes

@GregBrimble GregBrimble GregBrimble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CarmenPopoviciu @petebacondarwin @andyjessop @GregBrimble