Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @cloudflare/workers-shared as a dependency of wrangler #6431

Closed
wants to merge 1 commit into from

Conversation

GregBrimble
Copy link
Member

What this PR solves / how to test

Fixes #6429.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@GregBrimble GregBrimble requested a review from a team as a code owner August 6, 2024 16:48
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: ef71104

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-wrangler-6431

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6431/npm-package-wrangler-6431

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-wrangler-6431 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-create-cloudflare-6431 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-cloudflare-kv-asset-handler-6431
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-miniflare-6431
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-cloudflare-pages-shared-6431
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270798899/npm-package-cloudflare-vitest-pool-workers-6431

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble force-pushed the add-workers-shared-as-a-wrangler-dep branch from ae9e69d to ef71104 Compare August 6, 2024 17:00
@petebacondarwin
Copy link
Contributor

Closing in favour of #6432 - thanks @GregBrimble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants