Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on by default: –x-dev-env #6408

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

on by default: –x-dev-env #6408

wants to merge 4 commits into from

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Aug 2, 2024

What this PR solves / how to test

This PR updates the default value for --x-dev-env for wrangler dev (not yet for wrangler pages dev).

It also updates the e2e tests (which assumed the default value was false) to explicitly test with the flag on off (TODO: need to update the snapshots because this changed the test names)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: experimental flag

@RamIdeas RamIdeas requested a review from a team as a code owner August 2, 2024 15:43
Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: 461bd89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-wrangler-6408

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6408/npm-package-wrangler-6408

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-wrangler-6408 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-create-cloudflare-6408 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-cloudflare-kv-asset-handler-6408
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-miniflare-6408
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-cloudflare-pages-shared-6408
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10219710615/npm-package-cloudflare-vitest-pool-workers-6408

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants