Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RayID to wrangler login debug message #6315

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jul 22, 2024

What this PR solves / how to test

Further debgging for #3672. This PR adds the Ray ID to the error message printed by Wrangler, which can help when diagnosing these kinds of issues.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: change in messaging
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no e2e tests cover this code path
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: change in error messaging

@penalosa penalosa requested a review from a team as a code owner July 22, 2024 19:08
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 7cc7d5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-wrangler-6315

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6315/npm-package-wrangler-6315

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-wrangler-6315 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-create-cloudflare-6315 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-cloudflare-kv-asset-handler-6315
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-miniflare-6315
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-cloudflare-pages-shared-6315
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10046908126/npm-package-cloudflare-vitest-pool-workers-6315

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.0
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 3fd94e7 into main Jul 23, 2024
18 checks passed
@penalosa penalosa deleted the penalosa/login-ray-id branch July 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants