Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about deploying Python with requirements.txt #6258

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dom96
Copy link
Contributor

@dom96 dom96 commented Jul 12, 2024

What this PR solves / how to test

Refs cloudflare/python-workers-examples#11.

Added a sentence to the standard Python Workers warning, so that anyone using wrangler dev gets a warning about Python Workers with a requirements.txt not being deployable.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: simple change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: simple change

@dom96 dom96 requested a review from a team as a code owner July 12, 2024 18:49
Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 7d61bd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 12, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-wrangler-6258

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6258/npm-package-wrangler-6258

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-wrangler-6258 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-create-cloudflare-6258 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-cloudflare-kv-asset-handler-6258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-miniflare-6258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-cloudflare-pages-shared-6258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9912783692/npm-package-cloudflare-vitest-pool-workers-6258

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240701.0
workerd 1.20240701.0 1.20240701.0
workerd --version 1.20240701.0 2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@mikenomitch mikenomitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petebacondarwin petebacondarwin merged commit 4f524f2 into cloudflare:main Jul 15, 2024
18 checks passed
@dom96 dom96 deleted the patch-2 branch July 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants