-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix c3 astro e2es #6137
base: main
Are you sure you want to change the base?
fix c3 astro e2es #6137
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-wrangler-6137 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6137/npm-package-wrangler-6137 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-wrangler-6137 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-create-cloudflare-6137 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-cloudflare-kv-asset-handler-6137 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-miniflare-6137 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-cloudflare-pages-shared-6137 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9664099240/npm-package-cloudflare-vitest-pool-workers-6137 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
{ | ||
cwd: projectPath, | ||
}, | ||
logStream, | ||
); | ||
|
||
// Wait a few seconds for dev server to spin up | ||
await sleep(7000); | ||
await sleep(15000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to ping the server instead of waiting for an arbitrary? It might take only a few seconds on some machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes definitely 🙂
I did had it that way earlier in this PR too
anyways I am just messing around and trying to understand why the CI e2es are failing so this is not really code I necessarily want to commit 😅
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following