🦋 Changeset detected

Latest commit: c40ea53

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-wrangler-4545

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4545/npm-package-wrangler-4545

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-wrangler-4545 dev path/to/script.js

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-create-cloudflare-4545 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-cloudflare-kv-asset-handler-4545

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-miniflare-4545

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-cloudflare-pages-shared-4545

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10093248010/npm-package-cloudflare-vitest-pool-workers-4545

[email protected] includes the following runtime dependencies:

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Hey! 👋 To confirm, do the constellation commands still function at all today? Or will they error? Were constellation commands previously considered beta/experimental? Just want to make sure this isn't a semver major change. It may be better to "hide" the commands for the time being rather than removing them outright.

Hey! 👋 To confirm, do the constellation commands still function at all today? Or will they error? Were constellation commands previously considered beta/experimental? Just want to make sure this isn't a semver major change. It may be better to "hide" the commands for the time being rather than removing them outright.

constellation never left beta and was superseded by Workers AI. We checked the current usage and it's residual, I think we can safely deprecate the old command with the suggested warning.

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a6a4e8a) 75.16% compared to head (8614d5c) 74.95%.
Report is 46 commits behind head on main.

@@            Coverage Diff             @@
##             main    #4545       /-   ##
==========================================
- Coverage   75.16%   74.95%   -0.21%     
==========================================
  Files         242      232      -10     
  Lines       13014    12766     -248     
  Branches     3346     3317      -29     
==========================================
- Hits         9782     9569     -213     
  Misses       3232     3197      -35     

Sadly this needs a significant and non-trivial rebase 😢

I will do the rebase next week and ping you back 😁

Removal of any commands should always be a semver-major in my opinion. Beta/alpha designation aside, this is just good practice, and semver hygiene.

The commands are already deprecated, so what harm are they doing remaining there until the next major? As a user, I'd be concerned about what other deprecated things might end up removed in a minor release that I still use.

In addition, there's zero problems in my opinion releasing a semver major just for this, if the removal has to happen. Not every major version needs to be accompanied with a giant blog post, and multi-year migration guide that some folks will just never get to. Normalising majors that do simple things like bumping the minimum node version, or removing deprecated commands is not a bad thing, and very common in the JS ecosystem. The vast majority of folks will be able to upgrade immediately with no impacting changes, and that's only a good thing.

Thanks for your point of view @Cherry. I appreciate when you challenge our decisions.
We discussed this and we are comfortable that in this case the constellation stuff is fine to be removed without a major version bump. As mentioned earlier by the product owner:

constellation never left beta and was superseded by Workers AI. We checked the current usage and it's residual, I think we can safely deprecate the old command with the suggested warning.

Any user that still tries to run those commands will be given a clear message to use Workers AI.

Thanks @petebacondarwin. I disagree with the assessment, but I appreciate the insight.

I think it would probably be a good idea to more specifically define wrangler's approach to semver, experimental changes, and alpha/beta products in https://github.com/cloudflare/workers-sdk/blob/main/CONTRIBUTING.md#types-of-changes or similar. It's not really clear how this works or how semver is followed, with some commands/features introduced behind clear --experimental flags, and others not, or when/how these could have breaking changes, or be removed.

Hey @petebacondarwin rebase done
Feel free to merge if everything is correct