Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable middleware facades when not bundling #3894

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Disable middleware facades when not bundling #3894

wants to merge 1 commit into from

Conversation

GregBrimble
Copy link
Member

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7220776

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6860544102/npm-package-wrangler-3894

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6860544102/npm-package-wrangler-3894

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6860544102/npm-package-wrangler-3894 dev path/to/script.js
Additional artifacts: 
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6860544102/npm-package-miniflare-3894
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6860544102/npm-package-cloudflare-pages-shared-3894

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (be36619) to head (7220776).
Report is 1331 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3894    /-   ##
=======================================
  Coverage   75.46%   75.47%           
=======================================
  Files         225      225           
  Lines       12478    12481     3     
  Branches     3239     3242     3     
=======================================
  Hits         9417     9420     3     
  Misses       3061     3061
Files Coverage Δ
packages/wrangler/src/api/pages/deploy.tsx 86.15% <ø> (ø)
packages/wrangler/src/deployment-bundle/bundle.ts 88.13% <100.00%> ( 0.30%) ⬆️
packages/wrangler/src/pages/build.ts 70.11% <ø> (ø)
packages/wrangler/src/pages/dev.ts 16.20% <ø> (ø)
...ckages/wrangler/src/pages/functions/buildWorker.ts 71.87% <ø> (ø)

@GregBrimble GregBrimble force-pushed the disable-middleware-facades-when-not-bundling branch from 4d65ae1 to 99c85d9 Compare September 5, 2023 18:17
@GregBrimble GregBrimble force-pushed the disable-middleware-facades-when-not-bundling branch from 99c85d9 to 0999d1f Compare November 14, 2023 07:27
@GregBrimble GregBrimble force-pushed the disable-middleware-facades-when-not-bundling branch from 0999d1f to 7220776 Compare November 14, 2023 07:35
@GregBrimble GregBrimble force-pushed the disable-middleware-facades-when-not-bundling branch from 2a00873 to 7220776 Compare July 29, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregBrimble