Fix largest performance issue in profiler #1830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fallible conversion, since a peer could send an error code value that is unknown to quiche itself.
lib: Add TryFrom<u64> for WireErrorCode
|
@catid Thanks for the PR. I'm not quite sure how you were profiling but it doesn't seem like there should really be an issue from the allocation alone. Instead, there's work that can be skipped entirely if there is nothing to read on the QPACK stream . I made #1841 to address that, maybe you'd like to recheck your numbers with that change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not great at writing Rust code, but this was an easy fix. In callgrind it was using 38% of the CPU time of the application, and afterwards 0.