Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive): Improve flattening-skipped-group assert #5613

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(derive): Improve flattening-skipped-group assert #5613

merged 2 commits into from
Jul 31, 2024

Conversation

epage
Copy link
Member

@epage epage commented Jul 31, 2024

  • Improves the error message
  • Happens on initialization, rather than parse, making it so it will
    always show up and not just when certain parts of the CLI are
    exercised

Fixes #5609

@epage
test(derive): Show existing flatten behavior
4f875ff
@epage
fix(derive): Improve flattening-skipped-group assert
13dfdb3 
- Improves the error message
- Happens on initialization, rather than parse, making it so it will
  always show up and not just when certain parts of the CLI are
  exercised

Fixes clap-rs#5609
@epage epage merged commit 6671d93 into clap-rs:master Jul 31, 2024
23 checks passed
@epage epage deleted the flatten branch July 31, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear panic error: "#[arg(flatten)]ed field type implements Args::group_id"
1 participant
@epage