Skip to content

Latest commit

 

History

History
47 lines (34 loc) · 1.75 KB

cran-comments.md

File metadata and controls

47 lines (34 loc) · 1.75 KB

I have read and agree to the the CRAN policies at http://cran.r-project.org/web/packages/policies.html

Resubmission

This is a resubmission. In this version I have:

  • Write API names (AmeriFlux) in single quotes in title and description.
  • Add \value to amf_plot_datasummary.Rd amf_plot_datayear.Rd

Below is suggested by CRAN, but not changed. A brief explanation is included.

  • Please unwrap the examples if they are executable in < 5 sec, or replace \dontrun{} with \donttest{}.

    • Examples in functions that do not interact with an API are unwrapped. (e.g., amf_read_base.R, amf_read_bif.R, amf_extract_badm.R

    • Other functions deal with an API service are kept wrapped. Even if a server is online the services might not be or partially. Execution speeds and downloads could be low due to network latency and therefore hard to stick to the < 5 sec limit. We refer to the unit tests on github actions for test coverage.

In addition, I check the package using 'goodpractice' and 'lintr packages, and fix the style format as extensive as possible.

Test environments, local, GitHub-CI and r-hub

  • local x86_64-w64-mingw32/x64 (64-bit) install on R 4.1.0
  • GitHub CI windows-latest (release)
  • GitHub CI macOS-latest (release)
  • GitHub CI ubuntu-20.04 (release)
  • GitHub CI ubuntu-20.04 (devel)
  • codecove.io code coverage at ~80%
  • r-hub Windows Server 2022, R-devel, 64 bit
  • r-hub Ubuntu Linux 20.04.1 LTS, R-release, GCC
  • r-hub Fedora Linux, R-devel, clang, gfortran

Local / GitHub-CI R CMD check results

0 errors | 0 warnings | 1 notes

There was 1 NOTE:

  • r-hub Windows Server 2022, R-devel, 64 bit: Found the following files/directories: 'lastMiKTeXException'
    • I have tried my best effort but still can't replicate it locally.