[#16] Colour staged files #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I like the implementation! Really neat 🚀
There is still a loss of information in this implementation compared to calling git status - if a file is staged and then modified again, zbg status will now highlight the name green but git status would list the file as both staged and modified. Do you have any thoughts about this discrepancy?
I'm fine with this loss 👍🏻
I rarely want to edit a file, stage it, modify it again and commit only the staged part. So I'm fine with displaying it as staged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - this PR addresses issue 16 - Colour staged files in 'zbg status'.
I created a function to get a list of staged files using
git diff --name-only --cached [commit]. This is used so that I could get a list of staged files before callingwith_deleted_filesandwith_untracked_files(which temporarily stage deleted and untracked files). Then, we can pass the list of staged files along tofmt_diff_statsso we know which files we want to change to be green and bold.There is still a loss of information in this implementation compared to calling
git status- if a file is staged and then modified again,zbg statuswill now highlight the name green butgit statuswould list the file as both staged and modified. Do you have any thoughts about this discrepancy?Here's an example of the current behavior:
Let me know what changes you would like for me to make - I'm happy to rewrite if you think this problem should be solved differently. Thanks!