Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals module part 2 #1429

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

pitdicker
Copy link
Collaborator

These four commits are somewhat related as they all work on the ordinal part of a NaiveDate, or the ordinal leap year flag (ol).

@pitdicker pitdicker changed the title Refactor internals module part 1 Refactor internals module part 2 Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2e00a1c) 91.85% compared to head (c3c39eb) 91.84%.

Files Patch % Lines
src/naive/date.rs 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429       /-   ##
==========================================
- Coverage   91.85%   91.84%   -0.02%     
==========================================
  Files          38       38              
  Lines       17657    17628      -29     
==========================================
- Hits        16219    16190      -29     
  Misses       1438     1438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker force-pushed the refactor_internals_2 branch from adbfc7a to c3c39eb Compare February 12, 2024 10:23
@pitdicker pitdicker merged commit 5ba8ed1 into chronotope:main Feb 12, 2024
37 checks passed
@pitdicker pitdicker deleted the refactor_internals_2 branch February 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants