Remove warning when using --preview on stdin input
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case we should change the docs on the preview flag to something more descriptive. Right now it is /// Output result into stdout and do not modify files.
pub preview: bool, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #239
I agreed with the motivation from the original PR, but I have since changed my mind. Currently using
--previewwhen dealing with input from stdin is identical to not passing--preview, hence the idea behind the warning.The reason that I changed my mind is that I now view those two matching to be just a coincidence. The output of
--previewis likely to change in the future to be more human friendly while not passing--previewshould always pass the full expected output so it can be piped to other programs, files, etc. Because this is likely to change in the future I don"t think we should dissuade users from passing--previewwhile dealing with stdin input