Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: bump org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.21.0 #15799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dependency: bump org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.21.0 #15799

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2024 •
edited
Loading

Bumps org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.21.0.

Release notes

Sourced from org.apache.maven.plugins:maven-site-plugin's releases.

maven-site-plugin-3.20.0

Full Changelog: apache/maven-site-plugin@maven-site-plugin-3.12.1...maven-site-plugin-3.20.0

Commits
  • 43f73ec [maven-release-plugin] prepare release maven-site-plugin-3.21.0
  • a2880fb [MSITE-1024] Remove IT for MSITE-901
  • 6171e7d [MSITE-1023] Upgrade plugins and components (in ITs)
  • efd8a57 [MSITE-1022] Upgrade to Maven Reporting Exec 2.0.0
  • f5c5fc9 Fix typos in history.apt and faq.fml
  • 64c4035 [MSITE-1021] Bump doxiaSitetoolsVersion from 2.0.0-M19 to 2.0.0
  • e26765c [MSITE-1020] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M...
  • 354cf19 [MSITE-1019] Bump doxiaVersion from 2.0.0-M12 to 2.0.0
  • 67b568a Use '@​project.' instead of '@​pom.' expression prefix
  • fdfd807 Add version 3.20.0 to plugin history
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 22, 2024
@dependabot dependabot bot mentioned this pull request Oct 22, 2024
Closed
@romani romani added the blocked label Oct 22, 2024
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0 branch from 428cb7a to 3a4eb11 Compare October 22, 2024 22:36
@romani
Copy link
Member

romani commented Nov 5, 2024 

[INFO] Skipping org.apache.maven.plugins:maven-javadoc-plugin:3.10.1:javadoc report
[WARNING] Site model of 'com.puppycrawl.tools:checkstyle:jar:10.19.0-SNAPSHOT' 
for default locale is still using the old pre-version 2.0.0 model. You MUST migrate to
 the new model as soon as possible otherwise your build will break in the future!
[INFO] Relativizing site links with respect to localized project URL: https://checkstyle.org/
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.146 s
[INFO] Finished at: 2024-11-05T05:30:45-08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.21.0:site 
(default-site) on project checkstyle: Execution default-site of goal 
org.apache.maven.plugins:maven-site-plugin:3.21.0:site failed: skin cannot be null -> [Help 1]
[ERROR]

@romani
Copy link
Member

romani commented Nov 5, 2024 •
edited
Loading

@michael-o , do you know how to define skin for new maven plugin ?

I tried:

✔ ~/java/github/checkstyle/checkstyle [dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0|✚ 1] 
$ git diff
diff --git a/pom.xml b/pom.xml
index b596af6..4237bef 100644
--- a/pom.xml
    b/pom.xml
@@ -1351,6  1351,13 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
         <version>${maven.site.plugin.version}</version>
         <dependencies>
           <dependency>
             <groupId>org.apache.maven.skins</groupId>
             <artifactId>maven-fluido-skin</artifactId>
             <version>1.2.2</version>
           </dependency>
         </dependencies>
         <configuration>
           <xdocDirectory>${basedir}/src/xdocs</xdocDirectory>
           <validate>true</validate>

but this does not work.
Googling does not help to find details on migration.
May be you already knows good page that explains how to migrate. Thanks a lot in advance.

@michael-o
Copy link
Contributor

@michael-o , do you know how to define skin for new maven plugin ?

I tried:

✔ ~/java/github/checkstyle/checkstyle [dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0|✚ 1] 
$ git diff
diff --git a/pom.xml b/pom.xml
index b596af6..4237bef 100644
--- a/pom.xml
    b/pom.xml
@@ -1351,6  1351,13 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
         <version>${maven.site.plugin.version}</version>
         <dependencies>
           <dependency>
             <groupId>org.apache.maven.skins</groupId>
             <artifactId>maven-fluido-skin</artifactId>
             <version>1.2.2</version>
           </dependency>
         </dependencies>
         <configuration>
           <xdocDirectory>${basedir}/src/xdocs</xdocDirectory>
           <validate>true</validate>

but this does not work. Googling does not help to find details on migration. May be you already knows good page that explains how to migrate. Thanks a lot in advance.

You need to define it in your site.xml: https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html#class_skin

@romani romani force-pushed the dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0 branch from 3a4eb11 to 138106d Compare November 5, 2024 14:00
@romani
Copy link
Member

romani commented Nov 5, 2024 •
edited
Loading

thanks a lot.

workaround for bulid problem is:

~/java/github/checkstyle/checkstyle [dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0|✚ 1] 
$ git diff
diff --git a/src/site/site.xml b/src/site/site.xml
index 6ecde15..e48a3b3 100644
--- a/src/site/site.xml
    b/src/site/site.xml
@@ -5,6  5,11 @@
     xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.0
                         https://maven.apache.org/xsd/decoration-1.8.0.xsd">
 
   <skin>
     <groupId>org.apache.maven.skins</groupId>
     <artifactId>maven-fluido-skin</artifactId>
     <version>2.0.0-M11</version>
   </skin>
   <bannerLeft>
     <alt>Checkstyle</alt>
     <href>https://checkstyle.org</href>

but web site is broken and looks like needs more more tuning.

Skins: https://maven.apache.org/skins/index.html

@romani
Copy link
Member

romani commented Nov 5, 2024 •
edited
Loading

GitHub, generate website

Failure: https://github.com/checkstyle/checkstyle/actions/runs/11685772341/job/32540847864#step:3:60

@romani romani force-pushed the dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0 branch from 138106d to 7b69b5d Compare November 9, 2024 22:15
@romani
Copy link
Member

romani commented Nov 9, 2024

GitHub, generate website

@romani romani mentioned this pull request Nov 9, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7b69b5d_2024230057/index.html

dependabot bot and others added 2 commits November 9, 2024 15:45
@dependabot @romani
dependency: bump org.apache.maven.plugins:maven-site-plugin
098999f 
Bumps [org.apache.maven.plugins:maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.1 to 3.21.0.
- [Release notes](https://github.com/apache/maven-site-plugin/releases)
- [Commits](apache/maven-site-plugin@maven-site-plugin-3.12.1...maven-site-plugin-3.21.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-site-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@romani
infra: use fluido skin
aef7b48
@romani romani force-pushed the dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.21.0 branch from 7b69b5d to aef7b48 Compare November 9, 2024 23:45
@romani
Copy link
Member

romani commented Nov 9, 2024

GitHub, generate website

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024 •
edited by romani
Loading

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/aef7b48_2024234815/index.html
only index.html is rendered, all other pages are not , same on local.

michael-o
michael-o suggested changes Nov 22, 2024
View reviewed changes
src/site/site.xml
<skin>
<groupId>org.apache.maven.skins</groupId>
<artifactId>maven-fluido-skin</artifactId>
<version>2.0.0-M11</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the GA version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o requested changes

Assignees
No one assigned
Labels
blocked dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romani @michael-o