Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13213: Removed //ok from magicnumber #14411

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Feb 2, 2024

Part of #13213

Removed //ok comments from the following

  • InputMagicNumberDefault1.java
  • InputMagicNumberIgnoreFieldDeclaration1.java
  • InputMagicNumberIgnoreHashCodeMethod1.java
  • InputMagicNumberIgnoreNegativeOctalHex1.java
  • InputMagicNumberIntegersOnly1.java
  • InputMagicNumberLocalVariables.java
  • InputMagicNumberLocalVariables2.java
  • InputMagicNumberMagicNumber3.java
  • InputMagicNumberWaiverParentToken3.java

Copy link
Contributor

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge , thanks a lot

@romani romani merged commit 9554a53 into checkstyle:master Feb 3, 2024
112 of 113 checks passed
@Tahanima Tahanima deleted the issue-13213-magicnumber branch February 4, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants