Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update example of AST for TokenTypes.RPAREN #9566

Closed
pbludov opened this issue Mar 15, 2021 · 1 comment · Fixed by #9718
Closed

update example of AST for TokenTypes.RPAREN #9566

pbludov opened this issue Mar 15, 2021 · 1 comment · Fixed by #9718
Labels
approved good first issue miscellaneous
Milestone
8.42

Comments

@pbludov
Copy link
Member

pbludov commented Mar 15, 2021

https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#RPAREN

needs to be extended to show example of AST.
Source to be updated: https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java

PLEASE READ for more details: https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-AST-in-TokenTypes
Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Mar 24, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
54a6566
@Mitrajit Mitrajit mentioned this issue Mar 24, 2021
Merged
@Mitrajit
Copy link
Contributor

I have worked on the issue and submitted a PR #9718

Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Mar 24, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
f21bd4d 
1. method invocation on separate lines
2. -> replaced with ->
Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Apr 9, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
8bec077 
1. METHOD_DEF is changed to METHOD_CALL
Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Apr 19, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
3899f21
Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Apr 19, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
f9cb3a7
Mitrajit added a commit to Mitrajit/checkstyle that referenced this issue Apr 19, 2021
@Mitrajit
Issue checkstyle#9566: update example of AST for TokenTypes.RPAREN
e115fa0
romani pushed a commit that referenced this issue Apr 22, 2021
@Mitrajit @romani
Issue #9566: update example of AST for TokenTypes.RPAREN
75ae608
@romani romani added this to the 8.42 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good first issue miscellaneous
Projects
None yet
Milestone
8.42
Development

Successfully merging a pull request may close this issue.

Issue #9566: update example of AST for TokenTypes.RPAREN Mitrajit/checkstyle
3 participants
@romani @pbludov @Mitrajit