Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update example of AST for TokenTypes.LITERAL_IF #9480

Closed
pbludov opened this issue Mar 14, 2021 · 2 comments · Fixed by #9706
Closed

update example of AST for TokenTypes.LITERAL_IF #9480

pbludov opened this issue Mar 14, 2021 · 2 comments · Fixed by #9706
Labels
approved good first issue miscellaneous
Milestone
8.41.1

Comments

@pbludov
Copy link
Member

pbludov commented Mar 14, 2021

https://checkstyle.org/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_IF

needs to be extended to show example of AST.
Source to be updated: https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java

PLEASE READ for more details: https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-AST-in-TokenTypes
@theanmolsharma
Copy link
Contributor

I am working on this.

@theanmolsharma theanmolsharma mentioned this issue Mar 23, 2021
Merged
romani pushed a commit that referenced this issue Mar 27, 2021
@theanmolsharma @romani
Issue #9480: updated example of AST for TokenTypes.LITERAL_IF
ef21d30
@romani romani added this to the 8.42 milestone Mar 27, 2021
@romani
Copy link
Member

romani commented Mar 27, 2021

Fix is merged

jz20 pushed a commit to jz20/checkstyle that referenced this issue Mar 27, 2021
@theanmolsharma @jz20
Issue checkstyle#9480: updated example of AST for TokenTypes.LITERAL_IF
9fc5366
jz20 pushed a commit to jz20/checkstyle that referenced this issue Mar 27, 2021
@theanmolsharma @jz20
Issue checkstyle#9480: updated example of AST for TokenTypes.LITERAL_IF
9208a94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good first issue miscellaneous
Projects
None yet
Milestone
8.41.1
Development

Successfully merging a pull request may close this issue.

Issue #9480: updated example of AST for TokenTypes.LITERAL_IF
3 participants
@romani @pbludov @theanmolsharma