Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional label/title to diff report message #9177

Closed
strkkk opened this issue Jan 12, 2021 · 2 comments · Fixed by #9199
Closed

Add optional label/title to diff report message #9177

strkkk opened this issue Jan 12, 2021 · 2 comments · Fixed by #9199
Labels
approved miscellaneous
Milestone
8.40

Comments

@strkkk
Copy link
Member

strkkk commented Jan 12, 2021 •
edited
Loading

At the moment contributors cannot edit bot's messages. In case many reports are generated, it is not clear what is purpose of each report. Contributors have to assemble reports in one message.
Example of PR with many reports: #9096

Suggestion: include in PR description optional line "Report title:" and everything between it and EOL will be treated as report title. Message from job will add this title to message with report link.
For example, for PR description

Report title: My cool report
Diff Regression projects:: <link>
Diff Regression config:: <link>

Bot message will be:

Report: My cool report
<report link>

If there is no such line in PR description, bot message will have only link to report.
@nrmancuso
Copy link
Member

nrmancuso commented Jan 12, 2021 •
edited
Loading

@strkkk this is a great idea, it would clean things up a lot in PRs.

@strkkk
Copy link
Member Author

strkkk commented Jan 18, 2021

As an alternative, label can be added from comment, e.g. generation is triggered by Github, generate diff report, label: My cool report will produce same thing as in description

strkkk added a commit to strkkk/checkstyle that referenced this issue Jan 20, 2021
@strkkk
Issue checkstyle#9177: add label from for diff report from PR descrip…
0b5ab30 
…tion
@strkkk strkkk mentioned this issue Jan 20, 2021
Merged
strkkk added a commit to strkkk/checkstyle that referenced this issue Jan 20, 2021
@strkkk
Issue checkstyle#9177: add label for diff report from PR description
41bc8fc
strkkk added a commit to strkkk/checkstyle that referenced this issue Jan 21, 2021
@strkkk
Issue checkstyle#9177: add label for diff report from PR description
452ea9f
romani pushed a commit that referenced this issue Jan 22, 2021
@strkkk @romani
Issue #9177: add label for diff report from PR description
deb5ce1
@romani romani added this to the 8.40 milestone Jan 22, 2021
stryder2000 pushed a commit to stryder2000/checkstyle that referenced this issue Jan 23, 2021
@strkkk
Issue checkstyle#9177: add label for diff report from PR description
bdc828b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
8.40
Development

Successfully merging a pull request may close this issue.

Issue #9177: add label for diff report from PR description strkkk/checkstyle
3 participants
@romani @strkkk @nrmancuso