Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for VisibilityModifier #7616

Closed
pbludov opened this issue Feb 24, 2020 · 18 comments
Closed

Update doc for VisibilityModifier #7616

pbludov opened this issue Feb 24, 2020 · 18 comments
Labels
approved good first issue medium miscellaneous
Milestone
10.10.0

Comments

@pbludov
Copy link
Member

pbludov commented Feb 24, 2020 •
edited by romani
Loading

https://checkstyle.org/config_design.html#VisibilityModifier

The doc already has some examples, they should be formatted to match the common style.

Update example to show what code is ok and what code cause violation.
Good example is https://checkstyle.org/config_naming.html#AbstractClassName
Look at referenced commits of #5832, to see what and how should be changed in code.

Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.

PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples
@checkstyle checkstyle deleted a comment from sulkykookie Apr 2, 2020
@checkstyle checkstyle deleted a comment from DXTkastb Mar 12, 2021
@checkstyle checkstyle deleted a comment from aryaniiit002 Mar 24, 2022
@checkstyle checkstyle deleted a comment from AbhinavRajputEXE Jan 15, 2023
@checkstyle checkstyle deleted a comment from AbhinavRajputEXE Jan 15, 2023
@checkstyle checkstyle deleted a comment from AbhinavRajputEXE Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nrmancuso Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nrmancuso Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from aryaniiit002 Jan 15, 2023
@checkstyle checkstyle deleted a comment from phanendharreddy Feb 28, 2023
@checkstyle checkstyle deleted a comment from Zopsss Feb 28, 2023
@checkstyle checkstyle deleted a comment from phanendharreddy Feb 28, 2023
This was referenced Mar 2, 2023
Closed
Closed
@abhijeetgauravm
Copy link

Hey , I want to solve the issue can you please assign it to me?

@romani
Copy link
Member

romani commented Mar 10, 2023

@abhijeetdav24aug, please do, there is a PR already but it stuck.

@checkstyle checkstyle deleted a comment from Zopsss Mar 12, 2023
@checkstyle checkstyle deleted a comment from ShivanshCharak Mar 12, 2023
@checkstyle checkstyle deleted a comment from 0xbakry Mar 12, 2023
@Rishabh7798
Copy link

I want to work on this issue please assign me this task

@Mariam-maghraby
Copy link

Can I work on this issue?

@romani
Copy link
Member

romani commented Mar 18, 2023

@Mariam-maghraby, please do

@Almas456
Copy link

Can I work on this issue? pls assign it to me

@romani
Copy link
Member

romani commented Mar 19, 2023

@Almas456, no assignments, just sent pul request

@0xbakry 0xbakry mentioned this issue Mar 20, 2023
Closed
@SatyamDave
Copy link

I am working on it.

@sd9616
Copy link
Contributor

sd9616 commented Mar 23, 2023

I am on it

0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 23, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
548b2ac
@0xbakry 0xbakry mentioned this issue Mar 23, 2023
Merged
@romani
Copy link
Member

romani commented Mar 24, 2023

@sd9616, there is a active PR that is almost finished. Please look at another issue.

0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 24, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
1ceb77d
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 25, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
585b679
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 25, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
686f833
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 25, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
a304741
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 25, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
ccc0830
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 26, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
bc91e01
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 26, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
0579627
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 26, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
9250a47
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 28, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
6b326d8
@ankitkumarsingh778
Copy link

Hi @romani is this issue still open or finished.

@nrmancuso
Copy link
Member

@ankitkumarsingh778 we have a PR that is close to completion, please find another issue

0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 30, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
476539a
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 31, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
5bfb0ab
0xbakry added a commit to 0xbakry/checkstyle that referenced this issue Mar 31, 2023
@0xbakry
Issue checkstyle#7616: Add code example for VisibilityModifier check
8d07253
romani pushed a commit that referenced this issue Apr 1, 2023
@0xbakry @romani
Issue #7616: Add code example for VisibilityModifier check
97227d8
@romani
Copy link
Member

romani commented Apr 1, 2023

Fix is merged

@romani romani closed this as completed Apr 1, 2023
@github-actions github-actions bot added this to the 10.9.4 milestone Apr 1, 2023
Sloent pushed a commit to Sloent/checkstyle that referenced this issue Apr 18, 2023
@0xbakry @Sloent
Issue checkstyle#7616: Add code example for VisibilityModifier check
a8b1c94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good first issue medium miscellaneous
Projects
None yet
Milestone
10.10.0
Development

No branches or pull requests