-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google_checks SuppressionXpathSingleFilter for 'MethodName' check is too lenient in several ways #15609
Labels
Milestone
Comments
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 2, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 3, 2024
…uppressionXpathSingleFilter
Should be removed from issue description |
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 4, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 4, 2024
…uppressionXpathSingleFilter
We should allow digits immediately after underscore, reason explained at: #15617 (comment) |
I'll have a look. Thanks for the thorough review |
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 7, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 10, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 11, 2024
…uppressionXpathSingleFilter
mches
added a commit
to markitect-dev/checkstyle
that referenced
this issue
Sep 11, 2024
…uppressionXpathSingleFilter
Fix is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have read check documentation: https://checkstyle.org/filters/suppressionxpathsinglefilter.html
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words
Describe what you expect in detail.
The two illegally-named non-test methods should be reported e.g.
If approved, here is a proposal I would like to submit as a PR.
Before:
↓↓↓
After:
Note this proposal also accommodates fully-qualified test annotations. i.e.
The text was updated successfully, but these errors were encountered: