-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LITERAL_CASE token support in RightCurlyCheck #14620
Comments
@mahfouz72 thanks for your report, issue is approved. Tests for this need to include:
|
I am on it |
@nrmancuso but I found in the check code that the check is handling statements only not expressions so do you mean to add tests to show that it isn't getting checked? |
@mahfouz72 i like to think about issues vs PRs (generally) like this: in issues, we talk about behavior, and in PRs, we talk about code. As far as behavior goes, I would expect braces for the If RightCurlyCheck doesn’t check the closing right curly brace of a switch expression, this sounds like a different (but valid) issue. |
Currently RightCurlyCheck accepts a less tokens than LeftCurlyCheck (19 tokens)
This issue aims to add support for
LITERAL_CASE
token in RightCurlyCheckthis issue is a child issue for #3547
For LeftCurlyCheck:
for RightCurlyCheck:
Expected:- Violation for the right curly brace for
LITERAL_CASE
The text was updated successfully, but these errors were encountered: