-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checker.localeLanguage property work strange with system property user.language #12101
Comments
There is a secondary issue where we don't initialize new locale right away. Exceptions and probably other things who try to print localized messages will use the default locale before it is actually initialized from the config and will result in a similar issue. While we can't always guarantee this, it is just something else to consider. |
Closed via #12105 |
https://checkstyle.org/config.html#Checker_Properties
Starting audit doesn't obey config locale while check messages do.
I expect both outputs to be exactly the same since the configuration file specifies the language, but it turns out starting/finishing audits is in the OS language which for me is English.
Issue is DefaultLogger is only using the default locale
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java#L233
Migration notes for plugins:
please recheck code changes in api/Violation.java and how locale should be set.
The text was updated successfully, but these errors were encountered: