-
Notifications
You must be signed in to change notification settings - Fork 32
Feature: Update base branch
Josh Soref edited this page Sep 24, 2021
·
1 revision
The default workflow is (check-spelling is integrated into the base repo):
- Base branch has check-spelling.
- Forks from the base also have check-spelling.
- People can make a change to check-spelling in the fork / PR and it can merge into the base.
An alternative workflow is (check-spelling is not integrated into the base repo):
- Upstream doesn't have check-spelling
- Add check-spelling to a fork (e.g. check-spelling/zig)
- PR is made from a repo that still doesn't have check-spelling into one that does
- talk-to-the-bot knows that it can't update the HEAD of the PR, as that would obviously cause a conflict, so it's disabled
- check-spelling (classic) could know this, and give a command to update the BASE instead of the HEAD
- people could then push the updates to the BASE
- Teach classic to recognize the case (as talk-to-the-bot already does) and have it suggest patches to BASE instead of HEAD
- Teach talk-to-the-bot how to update HEAD instead of BASE -- this requires considering the permissions model a lot more. It might also involve a different set of commands, since the default is to both Add and Remove items from
expect.txt
. I'd be tempted to have it default to only adding, and require a fancier command for removal. A lot of work is required here.