Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce PolymorphismStyle.None #494

Merged
merged 7 commits into from
Jan 14, 2024
Merged

Introduce PolymorphismStyle.None #494

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift click to select a range
d53335e
Introduce PolymorphismStyle.None
ZacSweers Dec 14, 2023
b5d3fb7
Throw on tagged polymorphism when None is defined
ZacSweers Jan 9, 2024
523d98f
Error on polymorphic map with a diff message
ZacSweers Jan 9, 2024
986a65f
Add reading tests
ZacSweers Jan 9, 2024
6acd1ab
Spotless
ZacSweers Jan 9, 2024
89babba
Update src/commonTest/kotlin/com/charleskorn/kaml/YamlReadingTest.kt
charleskorn Jan 14, 2024
451593c
Update src/commonTest/kotlin/com/charleskorn/kaml/YamlReadingTest.kt
charleskorn Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Spotless
  • Loading branch information
@ZacSweers
ZacSweers committed Jan 9, 2024
commit 6acd1ab23bd74b76714a76e652c3a7662267ffc0
2 changes: 1 addition & 1 deletion src/commonMain/kotlin/com/charleskorn/kaml/YamlInput.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 65,7 @@ public sealed class YamlInput(
is PolymorphicKind -> when (configuration.polymorphismStyle) {
PolymorphismStyle.None ->
throw IncorrectTypeException("Encountered a polymorphic map descriptor but PolymorphismStyle is 'None'", node.path)
PolymorphismStyle.Tag, -> throw MissingTypeTagException(node.path)
PolymorphismStyle.Tag -> throw MissingTypeTagException(node.path)
PolymorphismStyle.Property -> createPolymorphicMapDeserializer(node, yaml, context, configuration)
}
else -> throw IncorrectTypeException("Expected ${descriptor.kind.friendlyDescription}, but got a map", node.path)
Expand Down